Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct small typos in vllm_mixtral.py #563

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Correct small typos in vllm_mixtral.py #563

merged 2 commits into from
Jan 26, 2024

Conversation

pbadeer
Copy link
Contributor

@pbadeer pbadeer commented Jan 25, 2024

Just fixing some small typos I spotted while walking through the guide!

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter
  • Example does not require third-party dependencies to be installed locally
  • Example is documented with comments throughout, in a Literate Programming style.

Outside contributors

You're great! Thanks for your contribution.

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes Jan 25, 2024
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

ekzhang
ekzhang approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ekzhang ekzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ekzhang ekzhang merged commit 55497df into modal-labs:main Jan 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modal-pr-review-automation modal-pr-review-automation[bot] modal-pr-review-automation[bot] approved these changes

@ekzhang ekzhang ekzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbadeer @ekzhang